浏览代码

底层系统日志级别调整,高频非核心日志调整为debug级别

xuxueli 7 年前
父节点
当前提交
45bac140b7

+ 1 - 0
doc/XXL-JOB官方文档.md 查看文件

@@ -1025,6 +1025,7 @@ Tips: 历史版本(V1.3.x)目前已经Release至稳定版本, 进入维护阶段
1025 1025
 - 4、修复任务监控线程无法监控任务触发和执行状态均未0的问题;
1026 1026
 - 5、调度中心项目日志配置改为xml文件格式;
1027 1027
 - 6、执行器动态代理对象,拦截非业务方法的执行;
1028
+- 7、底层系统日志级别规范调整,清理遗留代码;
1028 1029
 
1029 1030
 ### TODO LIST
1030 1031
 - 1、任务权限管理:执行器为粒度分配权限,核心操作校验权限;

+ 0 - 94
xxl-job-admin/src/main/java/com/xxl/job/admin/core/jobbean/LocalNomalJobBean.java 查看文件

@@ -1,94 +0,0 @@
1
-package com.xxl.job.admin.core.jobbean;
2
-//package com.xxl.job.action.job;
3
-//
4
-//import java.io.PrintWriter;
5
-//import java.io.StringWriter;
6
-//import java.util.Date;
7
-//import java.util.HashMap;
8
-//import java.util.Map;
9
-//
10
-//import org.apache.commons.lang.StringUtils;
11
-//import org.quartz.JobExecutionContext;
12
-//import org.quartz.JobExecutionException;
13
-//import org.quartz.JobKey;
14
-//import org.slf4j.Logger;
15
-//import org.slf4j.LoggerFactory;
16
-//import org.springframework.scheduling.quartz.QuartzJobBean;
17
-//
18
-//import com.xxl.job.client.handler.HandlerRouter;
19
-//import com.xxl.job.client.util.XxlJobNetCommUtil.RemoteCallBack;
20
-//import com.xxl.job.client.util.JacksonUtil;
21
-//import com.xxl.job.core.model.XxlJobInfo;
22
-//import com.xxl.job.core.model.XxlJobLog;
23
-//import com.xxl.job.core.thread.JobFailMonitorHelper;
24
-//import com.xxl.job.core.util.DynamicSchedulerUtil;
25
-//
26
-///**
27
-// * http job bean
28
-// * @author xuxueli 2015-12-17 18:20:34
29
-// */
30
-//@Deprecated
31
-//public abstract class LocalNomalJobBean extends QuartzJobBean {
32
-//	private static Logger logger = LoggerFactory.getLogger(LocalNomalJobBean.class);
33
-//
34
-//	@Override
35
-//	protected void executeInternal(JobExecutionContext context)
36
-//			throws JobExecutionException {
37
-//		JobKey jobKey = context.getTrigger().getJobKey();
38
-//		
39
-//		XxlJobInfo jobInfo = DynamicSchedulerUtil.xxlJobInfoDao.load(jobKey.getGroup(), jobKey.getName());
40
-//		@SuppressWarnings("unchecked")
41
-//		HashMap<String, String> jobDataMap = (HashMap<String, String>) JacksonUtil.readValueRefer(jobInfo.getJobData(), Map.class);
42
-//		
43
-//		// save log
44
-//		XxlJobLog jobLog = new XxlJobLog();
45
-//		jobLog.setJobGroup(jobInfo.getJobGroup());
46
-//		jobLog.setJobName(jobInfo.getJobName());
47
-//		jobLog.setJobCron(jobInfo.getJobCron());
48
-//		jobLog.setJobDesc(jobInfo.getJobDesc());
49
-//		jobLog.setJobClass(jobInfo.getJobClass());
50
-//		jobLog.setJobData(jobInfo.getJobData());
51
-//		
52
-//		jobLog.setJobClass(RemoteHttpJobBean.class.getName());
53
-//		jobLog.setJobData(jobInfo.getJobData());
54
-//		DynamicSchedulerUtil.xxlJobLogDao.save(jobLog);
55
-//		logger.info(">>>>>>>>>>> xxl-job trigger start, jobLog:{}", jobLog);
56
-//		
57
-//		// trigger request
58
-//		String handler_params = jobDataMap.get(HandlerRouter.HANDLER_PARAMS);
59
-//		String[] handlerParams = null;
60
-//		if (StringUtils.isNotBlank(handler_params)) {
61
-//			handlerParams = handler_params.split(",");
62
-//		}
63
-//		
64
-//		jobLog.setTriggerTime(new Date());
65
-//		jobLog.setTriggerStatus(RemoteCallBack.SUCCESS);
66
-//		jobLog.setTriggerMsg(null);
67
-//		
68
-//		try {
69
-//			Object responseMsg = this.handle(handlerParams);
70
-//			
71
-//			jobLog.setHandleTime(new Date());
72
-//			jobLog.setHandleStatus(RemoteCallBack.SUCCESS);
73
-//			jobLog.setHandleMsg(JacksonUtil.writeValueAsString(responseMsg));
74
-//		} catch (Exception e) {
75
-//			logger.info("JobThread Exception:", e);
76
-//			StringWriter out = new StringWriter();
77
-//			e.printStackTrace(new PrintWriter(out));
78
-//			
79
-//			jobLog.setHandleTime(new Date());
80
-//			jobLog.setHandleStatus(RemoteCallBack.FAIL);
81
-//			jobLog.setHandleMsg(out.toString());
82
-//		}
83
-//		
84
-//		// update trigger info
85
-//		DynamicSchedulerUtil.xxlJobLogDao.updateTriggerInfo(jobLog);
86
-//		DynamicSchedulerUtil.xxlJobLogDao.updateHandleInfo(jobLog);
87
-//		JobFailMonitorHelper.monitor(jobLog.getId());
88
-//		logger.info(">>>>>>>>>>> xxl-job trigger end, jobLog.id:{}, jobLog:{}", jobLog.getId(), jobLog);
89
-//		
90
-//    }
91
-//	
92
-//	public abstract Object handle(String... param);
93
-//	
94
-//}

+ 0 - 30
xxl-job-admin/src/main/java/com/xxl/job/admin/core/jobbean/impl/DemoConcurrentJobBean.java 查看文件

@@ -1,30 +0,0 @@
1
-package com.xxl.job.admin.core.jobbean.impl;
2
-//package com.xxl.job.action.job.impl;
3
-//
4
-//import java.util.concurrent.TimeUnit;
5
-//
6
-//import org.quartz.DisallowConcurrentExecution;
7
-//
8
-//import com.xxl.job.action.job.LocalNomalJobBean;
9
-//
10
-///**
11
-// * demo job bean for no-concurrent
12
-// * @author xuxueli 2016-3-12 14:25:14
13
-// */
14
-//@Deprecated
15
-//@DisallowConcurrentExecution	// 串行;线程数要多配置几个,否则不生效;
16
-//public class DemoConcurrentJobBean extends LocalNomalJobBean {
17
-//
18
-//	@Override
19
-//	public Object handle(String... param) {
20
-//		
21
-//		try {
22
-//			TimeUnit.SECONDS.sleep(10);
23
-//		} catch (InterruptedException e) {
24
-//			logger.error(e.getMessage(), e);
25
-//		}
26
-//		
27
-//		return false;
28
-//	}
29
-//
30
-//}

+ 0 - 32
xxl-job-admin/src/main/java/com/xxl/job/admin/core/jobbean/impl/DemoNomalJobBean.java 查看文件

@@ -1,32 +0,0 @@
1
-package com.xxl.job.admin.core.jobbean.impl;
2
-//package com.xxl.job.action.job.impl;
3
-//
4
-//import java.util.concurrent.TimeUnit;
5
-//
6
-//import org.slf4j.Logger;
7
-//import org.slf4j.LoggerFactory;
8
-//
9
-//import com.xxl.job.action.job.LocalNomalJobBean;
10
-//
11
-///**
12
-// * demo job bean for concurrent
13
-// * @author xuxueli 2016-3-12 14:25:57
14
-// */
15
-//@Deprecated
16
-//public class DemoNomalJobBean extends LocalNomalJobBean {
17
-//	private static Logger Logger = LoggerFactory.getLogger(DemoNomalJobBean.class);
18
-//	
19
-//	@Override
20
-//	public Object handle(String... param) {
21
-//		Logger.info("DemoNomalJobBean run :" + param);
22
-//		
23
-//		try {
24
-//			TimeUnit.SECONDS.sleep(10);
25
-//		} catch (InterruptedException e) {
26
-//			logger.error(e.getMessage(), e);
27
-//		}
28
-//		
29
-//		return false;
30
-//	}
31
-//
32
-//}

+ 1 - 1
xxl-job-admin/src/main/java/com/xxl/job/admin/core/thread/JobFailMonitorHelper.java 查看文件

@@ -63,7 +63,7 @@ public class JobFailMonitorHelper {
63 63
 									logger.info(">>>>>>>>>>> job monitor, job fail, JobLogId:{}", jobLogId);
64 64
 								} else {
65 65
 									JobFailMonitorHelper.monitor(jobLogId);
66
-									logger.info(">>>>>>>>>>> job monitor, job unknown, JobLogId:{}", jobLogId);
66
+									logger.info(">>>>>>>>>>> job monitor, job status unknown, JobLogId:{}", jobLogId);
67 67
 								}
68 68
 							}
69 69
 						}

+ 1 - 1
xxl-job-admin/src/main/java/com/xxl/job/admin/core/trigger/XxlJobTrigger.java 查看文件

@@ -35,7 +35,7 @@ public class XxlJobTrigger {
35 35
         // load data
36 36
         XxlJobInfo jobInfo = XxlJobDynamicScheduler.xxlJobInfoDao.loadById(jobId);              // job info
37 37
         if (jobInfo == null) {
38
-            logger.warn(">>>>>>>>>>>> xxl-job trigger fail, jobId invalid,jobId={}", jobId);
38
+            logger.warn(">>>>>>>>>>>> trigger fail, jobId invalid,jobId={}", jobId);
39 39
             return;
40 40
         }
41 41
         XxlJobGroup group = XxlJobDynamicScheduler.xxlJobGroupDao.load(jobInfo.getJobGroup());  // group info

+ 1 - 1
xxl-job-admin/src/main/java/com/xxl/job/admin/core/util/MailUtil.java 查看文件

@@ -93,7 +93,7 @@ public class MailUtil {
93 93
 			javaMailSender.send(mimeMessage);
94 94
 			return true;
95 95
 		} catch (Exception e) {
96
-			logger.info("{}", e);
96
+			logger.error(e.getMessage(), e);
97 97
 		}
98 98
 		return false;
99 99
 	}

+ 1 - 1
xxl-job-admin/src/main/java/com/xxl/job/admin/service/impl/AdminBizImpl.java 查看文件

@@ -45,7 +45,7 @@ public class AdminBizImpl implements AdminBiz {
45 45
     public ReturnT<String> callback(List<HandleCallbackParam> callbackParamList) {
46 46
         for (HandleCallbackParam handleCallbackParam: callbackParamList) {
47 47
             ReturnT<String> callbackResult = callback(handleCallbackParam);
48
-            logger.info("JobApiController.callback {}, handleCallbackParam={}, callbackResult={}",
48
+            logger.info(">>>>>>>>> JobApiController.callback {}, handleCallbackParam={}, callbackResult={}",
49 49
                     (callbackResult.getCode()==ReturnT.SUCCESS_CODE?"success":"fail"), handleCallbackParam, callbackResult);
50 50
         }
51 51
 

+ 1 - 1
xxl-job-core/src/main/java/com/xxl/job/core/log/XxlJobLogger.java 查看文件

@@ -43,7 +43,7 @@ public class XxlJobLogger {
43 43
         // appendlog
44 44
         XxlJobFileAppender.appendLog(logFileName, formatAppendLog);
45 45
 
46
-        logger.warn("[{}]: {}", logFileName, formatAppendLog);
46
+        logger.debug(">>>>>>>>>>> [{}]: {}", logFileName, formatAppendLog);
47 47
     }
48 48
 
49 49
     /**

+ 1 - 1
xxl-job-core/src/main/java/com/xxl/job/core/rpc/netcom/jetty/server/JettyServer.java 查看文件

@@ -44,7 +44,7 @@ public class JettyServer {
44 44
 				try {
45 45
 					// Start server
46 46
 					server.start();
47
-					logger.info(">>>>>>>>>>>> xxl-job jetty server start success at port:{}.", port);
47
+					logger.info(">>>>>>>>>>> xxl-job jetty server start success at port:{}.", port);
48 48
 
49 49
 					// Start Registry-Server
50 50
 					ExecutorRegistryThread.getInstance().start(port, ip, appName);

+ 3 - 3
xxl-job-core/src/main/java/com/xxl/job/core/thread/ExecutorRegistryThread.java 查看文件

@@ -28,11 +28,11 @@ public class ExecutorRegistryThread extends Thread {
28 28
 
29 29
         // valid
30 30
         if (appName==null || appName.trim().length()==0) {
31
-            logger.warn(">>>>>>>>>>>> xxl-job, executor registry config fail, appName is null.");
31
+            logger.warn(">>>>>>>>>>> xxl-job, executor registry config fail, appName is null.");
32 32
             return;
33 33
         }
34 34
         if (XxlJobExecutor.getAdminBizList() == null) {
35
-            logger.warn(">>>>>>>>>>>> xxl-job, executor registry config fail, adminAddresses is null.");
35
+            logger.warn(">>>>>>>>>>> xxl-job, executor registry config fail, adminAddresses is null.");
36 36
             return;
37 37
         }
38 38
 
@@ -99,7 +99,7 @@ public class ExecutorRegistryThread extends Thread {
99 99
                 } catch (Exception e) {
100 100
                     logger.error(e.getMessage(), e);
101 101
                 }
102
-                logger.warn(">>>>>>>>>>>> xxl-job, executor registry thread destory.");
102
+                logger.info(">>>>>>>>>>> xxl-job, executor registry thread destory.");
103 103
 
104 104
             }
105 105
         });

+ 2 - 2
xxl-job-core/src/main/java/com/xxl/job/core/thread/JobThread.java 查看文件

@@ -57,7 +57,7 @@ public class JobThread extends Thread{
57 57
 	public ReturnT<String> pushTriggerQueue(TriggerParam triggerParam) {
58 58
 		// avoid repeat
59 59
 		if (triggerLogIdSet.contains(triggerParam.getLogId())) {
60
-			logger.debug("repeate trigger job, logId:{}", triggerParam.getLogId());
60
+			logger.info(">>>>>>>>>>> repeate trigger job, logId:{}", triggerParam.getLogId());
61 61
 			return new ReturnT<String>(ReturnT.FAIL_CODE, "repeate trigger job, logId:" + triggerParam.getLogId());
62 62
 		}
63 63
 
@@ -171,6 +171,6 @@ public class JobThread extends Thread{
171 171
 			}
172 172
 		}
173 173
 		
174
-		logger.info(">>>>>>>>>>>> xxl-job JobThread stoped, hashCode:{}", Thread.currentThread());
174
+		logger.info(">>>>>>>>>>> xxl-job JobThread stoped, hashCode:{}", Thread.currentThread());
175 175
 	}
176 176
 }

+ 2 - 2
xxl-job-core/src/main/java/com/xxl/job/core/thread/TriggerCallbackThread.java 查看文件

@@ -40,7 +40,7 @@ public class TriggerCallbackThread {
40 40
 
41 41
         // valid
42 42
         if (XxlJobExecutor.getAdminBizList() == null) {
43
-            logger.warn(">>>>>>>>>>>> xxl-job, executor callback config fail, adminAddresses is null.");
43
+            logger.warn(">>>>>>>>>>> xxl-job, executor callback config fail, adminAddresses is null.");
44 44
             return;
45 45
         }
46 46
 
@@ -80,7 +80,7 @@ public class TriggerCallbackThread {
80 80
                 } catch (Exception e) {
81 81
                     logger.error(e.getMessage(), e);
82 82
                 }
83
-                logger.warn(">>>>>>>>>>>> xxl-job, executor callback thread destory.");
83
+                logger.info(">>>>>>>>>>> xxl-job, executor callback thread destory.");
84 84
 
85 85
             }
86 86
         });

+ 1 - 1
xxl-job-core/src/main/java/com/xxl/job/core/util/HttpClientUtil.java 查看文件

@@ -64,7 +64,7 @@ public class HttpClientUtil {
64 64
 				EntityUtils.consume(entity);
65 65
 			}
66 66
 		} catch (Exception e) {
67
-			logger.error("", e);
67
+			logger.error(e.getMessage(), e);
68 68
 			throw e;
69 69
 		} finally {
70 70
 			httpPost.releaseConnection();