xuxueli 6 年 前
コミット
9ac897f5db

+ 0 - 1
doc/db/tables_xxl_job.sql ファイルの表示

@@ -176,7 +176,6 @@ CREATE TABLE `XXL_JOB_QRTZ_TRIGGER_LOG` (
176 176
   `id` int(11) NOT NULL AUTO_INCREMENT,
177 177
   `job_group` int(11) NOT NULL COMMENT '执行器主键ID',
178 178
   `job_id` int(11) NOT NULL COMMENT '任务,主键ID',
179
-  `glue_type` varchar(50) DEFAULT NULL COMMENT 'GLUE类型',
180 179
   `executor_address` varchar(255) DEFAULT NULL COMMENT '执行器地址,本次执行的地址',
181 180
   `executor_handler` varchar(255) DEFAULT NULL COMMENT '执行器任务handler',
182 181
   `executor_param` varchar(512) DEFAULT NULL COMMENT '执行器任务参数',

+ 0 - 11
xxl-job-admin/src/main/java/com/xxl/job/admin/core/model/XxlJobLog.java ファイルの表示

@@ -14,9 +14,6 @@ public class XxlJobLog {
14 14
 	private int jobGroup;
15 15
 	private int jobId;
16 16
 
17
-	// glueType
18
-	private String glueType;
19
-
20 17
 	// execute info
21 18
 	private String executorAddress;
22 19
 	private String executorHandler;
@@ -57,14 +54,6 @@ public class XxlJobLog {
57 54
 		this.jobId = jobId;
58 55
 	}
59 56
 
60
-	public String getGlueType() {
61
-		return glueType;
62
-	}
63
-
64
-	public void setGlueType(String glueType) {
65
-		this.glueType = glueType;
66
-	}
67
-
68 57
 	public String getExecutorAddress() {
69 58
 		return executorAddress;
70 59
 	}

+ 12 - 12
xxl-job-admin/src/main/java/com/xxl/job/admin/core/trigger/XxlJobTrigger.java ファイルの表示

@@ -70,7 +70,6 @@ public class XxlJobTrigger {
70 70
 
71 71
                 // 2、prepare trigger-info
72 72
                 //jobLog.setExecutorAddress(executorAddress);
73
-                jobLog.setGlueType(jobInfo.getGlueType());
74 73
                 jobLog.setExecutorHandler(jobInfo.getExecutorHandler());
75 74
                 jobLog.setExecutorParam(jobInfo.getExecutorParam());
76 75
                 jobLog.setExecutorFailRetryCount(finalFailRetryCount);
@@ -108,7 +107,7 @@ public class XxlJobTrigger {
108 107
                 triggerMsgSb.append("<br><br><span style=\"color:#00c0ef;\" > >>>>>>>>>>>"+ I18nUtil.getString("jobconf_trigger_run") +"<<<<<<<<<<< </span><br>").append(triggerResult.getMsg());
109 108
 
110 109
 
111
-                // 3.3、trigger (fail retry)
110
+                // 4、fail retry)
112 111
                 if (triggerResult.getCode()!=ReturnT.SUCCESS_CODE) {
113 112
                     onceFailed = true;
114 113
                 }
@@ -118,13 +117,13 @@ public class XxlJobTrigger {
118 117
                     triggerMsgSb.append("<br><br><span style=\"color:#F39C12;\" > >>>>>>>>>>>"+ I18nUtil.getString("jobconf_fail_trigger_retry") +"<<<<<<<<<<< </span><br>");
119 118
                 }
120 119
 
121
-                // 4、save trigger-info
120
+                // 5、save trigger-info
122 121
                 jobLog.setExecutorAddress(triggerResult.getContent());
123 122
                 jobLog.setTriggerCode(triggerResult.getCode());
124 123
                 jobLog.setTriggerMsg(triggerMsgSb.toString());
125 124
                 XxlJobDynamicScheduler.xxlJobLogDao.updateTriggerInfo(jobLog);
126 125
 
127
-                // 5、monitor trigger
126
+                // 6、monitor trigger
128 127
                 JobFailMonitorHelper.monitor(jobLog.getId());
129 128
                 logger.debug(">>>>>>>>>>> xxl-job trigger end, jobId:{}", jobLog.getId());
130 129
 
@@ -140,7 +139,6 @@ public class XxlJobTrigger {
140 139
 
141 140
             // 2、prepare trigger-info
142 141
             //jobLog.setExecutorAddress(executorAddress);
143
-            jobLog.setGlueType(jobInfo.getGlueType());
144 142
             jobLog.setExecutorHandler(jobInfo.getExecutorHandler());
145 143
             jobLog.setExecutorParam(jobInfo.getExecutorParam());
146 144
             jobLog.setExecutorFailRetryCount(finalFailRetryCount);
@@ -181,20 +179,22 @@ public class XxlJobTrigger {
181 179
                 triggerResult = executorRouteStrategyEnum.getRouter().routeRun(triggerParam, addressList);
182 180
                 triggerMsgSb.append("<br><br><span style=\"color:#00c0ef;\" > >>>>>>>>>>>"+ I18nUtil.getString("jobconf_trigger_run") +"<<<<<<<<<<< </span><br>").append(triggerResult.getMsg());
183 181
 
184
-                // 3.3、trigger (fail retry)
185
-                if (triggerResult.getCode()!=ReturnT.SUCCESS_CODE && finalFailRetryCount > 0) {
186
-                    JobTriggerPoolHelper.trigger(jobId, (finalFailRetryCount-1));
187
-                    triggerMsgSb.append("<br><br><span style=\"color:#F39C12;\" > >>>>>>>>>>>"+ I18nUtil.getString("jobconf_fail_trigger_retry") +"<<<<<<<<<<< </span><br>");
188
-                }
182
+
183
+            }
184
+
185
+            // 4、fail retry
186
+            if (triggerResult.getCode()!=ReturnT.SUCCESS_CODE && finalFailRetryCount > 0) {
187
+                JobTriggerPoolHelper.trigger(jobId, (finalFailRetryCount-1));
188
+                triggerMsgSb.append("<br><br><span style=\"color:#F39C12;\" > >>>>>>>>>>>"+ I18nUtil.getString("jobconf_fail_trigger_retry") +"<<<<<<<<<<< </span><br>");
189 189
             }
190 190
 
191
-            // 4、save trigger-info
191
+            // 5、save trigger-info
192 192
             jobLog.setExecutorAddress(triggerResult.getContent());
193 193
             jobLog.setTriggerCode(triggerResult.getCode());
194 194
             jobLog.setTriggerMsg(triggerMsgSb.toString());
195 195
             XxlJobDynamicScheduler.xxlJobLogDao.updateTriggerInfo(jobLog);
196 196
 
197
-            // 5、monitor trigger
197
+            // 6、monitor trigger
198 198
             JobFailMonitorHelper.monitor(jobLog.getId());
199 199
             logger.debug(">>>>>>>>>>> xxl-job trigger end, jobId:{}", jobLog.getId());
200 200
         }

+ 2 - 0
xxl-job-admin/src/main/java/com/xxl/job/admin/service/impl/AdminBizImpl.java ファイルの表示

@@ -96,6 +96,8 @@ public class AdminBizImpl implements AdminBiz {
96 96
             if (log.getExecutorFailRetryCount() > 0) {
97 97
                 int nextFailRetryCount = log.getExecutorFailRetryCount()-1;
98 98
 
99
+                // TODO,广播路由的失败重试,会导致重试暴增,需要优化
100
+
99 101
                 JobTriggerPoolHelper.trigger(log.getJobId(), nextFailRetryCount);
100 102
 
101 103
                 callbackMsg = "<br><br><span style=\"color:#F39C12;\" > >>>>>>>>>>>"+ I18nUtil.getString("jobconf_fail_handle_retry") +"<<<<<<<<<<< </span><br>";

+ 0 - 4
xxl-job-admin/src/main/resources/mybatis-mapper/XxlJobLogMapper.xml ファイルの表示

@@ -9,8 +9,6 @@
9 9
 		<result column="job_group" property="jobGroup" />
10 10
 		<result column="job_id" property="jobId" />
11 11
 
12
-		<result column="glue_type" property="glueType" />
13
-
14 12
 		<result column="executor_address" property="executorAddress" />
15 13
 		<result column="executor_handler" property="executorHandler" />
16 14
 	    <result column="executor_param" property="executorParam" />
@@ -30,7 +28,6 @@
30 28
 		t.id,
31 29
 		t.job_group,
32 30
 		t.job_id,
33
-		t.glue_type,
34 31
 		t.executor_address,
35 32
 		t.executor_handler,
36 33
 		t.executor_param,
@@ -136,7 +133,6 @@
136 133
 	<update id="updateTriggerInfo" >
137 134
 		UPDATE XXL_JOB_QRTZ_TRIGGER_LOG
138 135
 		SET
139
-		    `glue_type`= #{glueType},
140 136
 			`trigger_time`= #{triggerTime},
141 137
 			`trigger_code`= #{triggerCode},
142 138
 			`trigger_msg`= #{triggerMsg},