ソースを参照

心跳注册和结果回调,重试逻辑优化

xuxueli 8 年 前
コミット
02818b4d6b

+ 1 - 0
doc/XXL-JOB官方文档.md ファイルの表示

@@ -903,6 +903,7 @@ Tips: 历史版本(V1.3.x)目前已经Release至稳定版本, 进入维护阶段
903 903
 - 4、执行器集群地址列表进行自然排序;
904 904
 - 5、调度中心,DAO层代码精简优化并且新增测试用例覆盖;
905 905
 - 6、调度中心API服务改为自研RPC形式,统一底层通讯模型;
906
+- 7、新增调度中心API服务测试Demo,方便在调度中心API扩展和测试;
906 907
 
907 908
 #### TODO LIST
908 909
 - 1、任务权限管理:执行器为粒度分配权限,核心操作校验权限;

+ 2 - 1
xxl-job-admin/src/main/java/com/xxl/job/admin/controller/JobApiController.java ファイルの表示

@@ -1,6 +1,7 @@
1 1
 package com.xxl.job.admin.controller;
2 2
 
3 3
 import com.xxl.job.admin.controller.annotation.PermessionLimit;
4
+import com.xxl.job.core.biz.AdminBiz;
4 5
 import com.xxl.job.core.rpc.codec.RpcRequest;
5 6
 import com.xxl.job.core.rpc.codec.RpcResponse;
6 7
 import com.xxl.job.core.rpc.netcom.NetComServerFactory;
@@ -46,7 +47,7 @@ public class JobApiController {
46 47
         }
47 48
     }
48 49
 
49
-    @RequestMapping("/api")
50
+    @RequestMapping(AdminBiz.MAPPING)
50 51
     @PermessionLimit(limit=false)
51 52
     public void api(HttpServletRequest request, HttpServletResponse response) throws IOException {
52 53
 

+ 9 - 6
xxl-job-admin/src/main/java/com/xxl/job/admin/controller/JobLogController.java ファイルの表示

@@ -12,6 +12,8 @@ import com.xxl.job.core.biz.model.ReturnT;
12 12
 import com.xxl.job.core.rpc.netcom.NetComClientProxy;
13 13
 import org.apache.commons.lang.StringUtils;
14 14
 import org.apache.commons.lang.time.DateUtils;
15
+import org.slf4j.Logger;
16
+import org.slf4j.LoggerFactory;
15 17
 import org.springframework.stereotype.Controller;
16 18
 import org.springframework.ui.Model;
17 19
 import org.springframework.web.bind.annotation.RequestMapping;
@@ -32,6 +34,7 @@ import java.util.Map;
32 34
 @Controller
33 35
 @RequestMapping("/joblog")
34 36
 public class JobLogController {
37
+	private static Logger logger = LoggerFactory.getLogger(JobLogController.class);
35 38
 
36 39
 	@Resource
37 40
 	private XxlJobGroupDao xxlJobGroupDao;
@@ -129,7 +132,7 @@ public class JobLogController {
129 132
 
130 133
 			return logResult;
131 134
 		} catch (Exception e) {
132
-			e.printStackTrace();
135
+			logger.error(e.getMessage(), e);
133 136
 			return new ReturnT<LogResult>(ReturnT.FAIL_CODE, e.getMessage());
134 137
 		}
135 138
 	}
@@ -148,14 +151,14 @@ public class JobLogController {
148 151
 		}
149 152
 
150 153
 		// request of kill
151
-		ExecutorBiz executorBiz = null;
154
+		ReturnT<String> runResult = null;
152 155
 		try {
153
-			executorBiz = (ExecutorBiz) new NetComClientProxy(ExecutorBiz.class, log.getExecutorAddress()).getObject();
156
+			ExecutorBiz executorBiz = (ExecutorBiz) new NetComClientProxy(ExecutorBiz.class, log.getExecutorAddress()).getObject();
157
+			runResult = executorBiz.kill(jobInfo.getId());
154 158
 		} catch (Exception e) {
155
-			e.printStackTrace();
156
-			return new ReturnT<String>(500, e.getMessage());
159
+			logger.error(e.getMessage(), e);
160
+			runResult = new ReturnT<String>(500, e.getMessage());
157 161
 		}
158
-		ReturnT<String> runResult = executorBiz.kill(jobInfo.getId());
159 162
 
160 163
 		if (ReturnT.SUCCESS_CODE == runResult.getCode()) {
161 164
 			log.setHandleCode(ReturnT.FAIL_CODE);

+ 1 - 1
xxl-job-admin/src/main/java/com/xxl/job/admin/core/route/ExecutorRouter.java ファイルの表示

@@ -36,7 +36,7 @@ public abstract class ExecutorRouter {
36 36
             ExecutorBiz executorBiz = (ExecutorBiz) new NetComClientProxy(ExecutorBiz.class, address).getObject();
37 37
             runResult = executorBiz.run(triggerParam);
38 38
         } catch (Exception e) {
39
-            logger.error("", e);
39
+            logger.error(e.getMessage(), e);
40 40
             runResult = new ReturnT<String>(ReturnT.FAIL_CODE, ""+e );
41 41
         }
42 42
 

+ 31 - 0
xxl-job-admin/src/test/java/com/xxl/job/dao/impl/AdminBizTest.java ファイルの表示

@@ -0,0 +1,31 @@
1
+package com.xxl.job.dao.impl;
2
+
3
+import com.xxl.job.core.biz.AdminBiz;
4
+import com.xxl.job.core.biz.model.RegistryParam;
5
+import com.xxl.job.core.biz.model.ReturnT;
6
+import com.xxl.job.core.enums.RegistryConfig;
7
+import com.xxl.job.core.rpc.netcom.NetComClientProxy;
8
+import org.junit.Assert;
9
+import org.junit.Test;
10
+
11
+/**
12
+ * admin-api client, test
13
+ * @author xuxueli 2017-07-28 22:14:52
14
+ */
15
+public class AdminBizTest {
16
+
17
+    @Test
18
+    public void registryTest() throws Exception {
19
+
20
+        // admin-client
21
+        String addressUrl = "http://127.0.0.1:8080/xxl-job-admin".concat(AdminBiz.MAPPING);
22
+        AdminBiz adminBiz = (AdminBiz) new NetComClientProxy(AdminBiz.class, addressUrl).getObject();
23
+
24
+        // test executor registry
25
+        RegistryParam registryParam = new RegistryParam(RegistryConfig.RegistType.EXECUTOR.name(), "xxl-job-executor-example", "127.0.0.1:9999");
26
+        ReturnT<String> returnT = adminBiz.registry(registryParam);
27
+        Assert.assertTrue(returnT.getCode() == ReturnT.SUCCESS_CODE);
28
+
29
+    }
30
+
31
+}

+ 2 - 0
xxl-job-core/src/main/java/com/xxl/job/core/biz/AdminBiz.java ファイルの表示

@@ -11,6 +11,8 @@ import java.util.List;
11 11
  */
12 12
 public interface AdminBiz {
13 13
 
14
+    public static final String MAPPING = "/api";
15
+
14 16
     /**
15 17
      * callback
16 18
      *

+ 1 - 1
xxl-job-core/src/main/java/com/xxl/job/core/executor/XxlJobExecutor.java ファイルの表示

@@ -58,7 +58,7 @@ public class XxlJobExecutor implements ApplicationContextAware, ApplicationListe
58 58
         if (adminAddresses!=null && adminAddresses.trim().length()>0) {
59 59
             for (String address: adminAddresses.trim().split(",")) {
60 60
                 if (address!=null && address.trim().length()>0) {
61
-                    String addressUrl = address.concat("/api");
61
+                    String addressUrl = address.concat(AdminBiz.MAPPING);
62 62
                     AdminBiz adminBiz = (AdminBiz) new NetComClientProxy(AdminBiz.class, addressUrl).getObject();
63 63
                     if (adminBizList == null) {
64 64
                         adminBizList = new ArrayList<AdminBiz>();

+ 2 - 0
xxl-job-executor-example/src/test/java/com/xxl/executor/test/DemoJobHandlerTest.java ファイルの表示

@@ -8,6 +8,8 @@ import com.xxl.job.core.glue.GlueTypeEnum;
8 8
 import com.xxl.job.core.rpc.netcom.NetComClientProxy;
9 9
 
10 10
 /**
11
+ * executor-api client, test
12
+ *
11 13
  * Created by xuxueli on 17/5/12.
12 14
  */
13 15
 public class DemoJobHandlerTest {