Przeglądaj źródła

任务回调结果优化,支持展示在Rolling log中,方便问题排查

xuxueli 7 lat temu
rodzic
commit
22da65c215

+ 1 - 1
doc/XXL-JOB官方文档.md Wyświetl plik

@@ -1199,7 +1199,7 @@ Tips: 历史版本(V1.3.x)目前已经Release至稳定版本, 进入维护阶段
1199 1199
 - 8、Window机器下File.separator不兼容问题修复;
1200 1200
 - 9、任务日志查询速度优化,百万级别日志量搜索速度提升1000倍;
1201 1201
 - 10、底层LocalCache组件兼容性优化,支持jdk、jdk10编译部署;
1202
-- 11、[迭代中]回调log优化,支持展示在rolling log中,方便排查问题
1202
+- 11、任务回调结果优化,支持展示在Rolling log中,方便问题排查
1203 1203
 - 12、脚本任务异常Log输出优化;
1204 1204
 
1205 1205
 

+ 14 - 1
xxl-job-core/src/main/java/com/xxl/job/core/biz/model/HandleCallbackParam.java Wyświetl plik

@@ -9,11 +9,14 @@ public class HandleCallbackParam implements Serializable {
9 9
     private static final long serialVersionUID = 42L;
10 10
 
11 11
     private int logId;
12
+    private long logDateTim;
13
+
12 14
     private ReturnT<String> executeResult;
13 15
 
14 16
     public HandleCallbackParam(){}
15
-    public HandleCallbackParam(int logId, ReturnT<String> executeResult) {
17
+    public HandleCallbackParam(int logId, long logDateTim, ReturnT<String> executeResult) {
16 18
         this.logId = logId;
19
+        this.logDateTim = logDateTim;
17 20
         this.executeResult = executeResult;
18 21
     }
19 22
 
@@ -25,6 +28,14 @@ public class HandleCallbackParam implements Serializable {
25 28
         this.logId = logId;
26 29
     }
27 30
 
31
+    public long getLogDateTim() {
32
+        return logDateTim;
33
+    }
34
+
35
+    public void setLogDateTim(long logDateTim) {
36
+        this.logDateTim = logDateTim;
37
+    }
38
+
28 39
     public ReturnT<String> getExecuteResult() {
29 40
         return executeResult;
30 41
     }
@@ -37,7 +48,9 @@ public class HandleCallbackParam implements Serializable {
37 48
     public String toString() {
38 49
         return "HandleCallbackParam{" +
39 50
                 "logId=" + logId +
51
+                ", logDateTim=" + logDateTim +
40 52
                 ", executeResult=" + executeResult +
41 53
                 '}';
42 54
     }
55
+
43 56
 }

+ 3 - 4
xxl-job-core/src/main/java/com/xxl/job/core/thread/JobThread.java Wyświetl plik

@@ -14,7 +14,6 @@ import org.slf4j.LoggerFactory;
14 14
 
15 15
 import java.io.PrintWriter;
16 16
 import java.io.StringWriter;
17
-import java.util.Arrays;
18 17
 import java.util.Date;
19 18
 import java.util.concurrent.LinkedBlockingQueue;
20 19
 import java.util.concurrent.TimeUnit;
@@ -148,11 +147,11 @@ public class JobThread extends Thread{
148 147
                     // callback handler info
149 148
                     if (!toStop) {
150 149
                         // commonm
151
-                        TriggerCallbackThread.pushCallBack(new HandleCallbackParam(triggerParam.getLogId(), executeResult));
150
+                        TriggerCallbackThread.pushCallBack(new HandleCallbackParam(triggerParam.getLogId(), triggerParam.getLogDateTim(), executeResult));
152 151
                     } else {
153 152
                         // is killed
154 153
                         ReturnT<String> stopResult = new ReturnT<String>(ReturnT.FAIL_CODE, stopReason + " [业务运行中,被强制终止]");
155
-                        TriggerCallbackThread.pushCallBack(new HandleCallbackParam(triggerParam.getLogId(), stopResult));
154
+                        TriggerCallbackThread.pushCallBack(new HandleCallbackParam(triggerParam.getLogId(), triggerParam.getLogDateTim(), stopResult));
156 155
                     }
157 156
                 }
158 157
             }
@@ -164,7 +163,7 @@ public class JobThread extends Thread{
164 163
 			if (triggerParam!=null) {
165 164
 				// is killed
166 165
 				ReturnT<String> stopResult = new ReturnT<String>(ReturnT.FAIL_CODE, stopReason + " [任务尚未执行,在调度队列中被终止]");
167
-				TriggerCallbackThread.pushCallBack(new HandleCallbackParam(triggerParam.getLogId(), stopResult));
166
+				TriggerCallbackThread.pushCallBack(new HandleCallbackParam(triggerParam.getLogId(), triggerParam.getLogDateTim(), stopResult));
168 167
 			}
169 168
 		}
170 169
 

+ 17 - 4
xxl-job-core/src/main/java/com/xxl/job/core/thread/TriggerCallbackThread.java Wyświetl plik

@@ -4,10 +4,13 @@ import com.xxl.job.core.biz.AdminBiz;
4 4
 import com.xxl.job.core.biz.model.HandleCallbackParam;
5 5
 import com.xxl.job.core.biz.model.ReturnT;
6 6
 import com.xxl.job.core.executor.XxlJobExecutor;
7
+import com.xxl.job.core.log.XxlJobFileAppender;
8
+import com.xxl.job.core.log.XxlJobLogger;
7 9
 import org.slf4j.Logger;
8 10
 import org.slf4j.LoggerFactory;
9 11
 
10 12
 import java.util.ArrayList;
13
+import java.util.Date;
11 14
 import java.util.List;
12 15
 import java.util.concurrent.LinkedBlockingQueue;
13 16
 
@@ -108,17 +111,27 @@ public class TriggerCallbackThread {
108 111
             try {
109 112
                 ReturnT<String> callbackResult = adminBiz.callback(callbackParamList);
110 113
                 if (callbackResult!=null && ReturnT.SUCCESS_CODE == callbackResult.getCode()) {
111
-                    callbackResult = ReturnT.SUCCESS;
112
-                    logger.info(">>>>>>>>>>> xxl-job callback success, callbackParamList:{}, callbackResult:{}", new Object[]{callbackParamList, callbackResult});
114
+                    callbackLog(callbackParamList, "<br>----------- xxl-job callback success");
113 115
                     break;
114 116
                 } else {
115
-                    logger.info(">>>>>>>>>>> xxl-job callback fail, callbackParamList:{}, callbackResult:{}", new Object[]{callbackParamList, callbackResult});
117
+                    callbackLog(callbackParamList, "<br>----------- xxl-job callback fail, callbackResult:" + callbackResult);
116 118
                 }
117 119
             } catch (Exception e) {
118
-                logger.error(">>>>>>>>>>> xxl-job callback error, callbackParamList:{}", callbackParamList, e);
120
+                callbackLog(callbackParamList, "<br>----------- xxl-job callback error, errorMsg:" + e.getMessage());
119 121
                 //getInstance().callBackQueue.addAll(callbackParamList);
120 122
             }
121 123
         }
122 124
     }
123 125
 
126
+    /**
127
+     * callback log
128
+     */
129
+    private void callbackLog(List<HandleCallbackParam> callbackParamList, String logContent){
130
+        for (HandleCallbackParam callbackParam: callbackParamList) {
131
+            String logFileName = XxlJobFileAppender.makeLogFileName(new Date(callbackParam.getLogDateTim()), callbackParam.getLogId());
132
+            XxlJobFileAppender.contextHolder.set(logFileName);
133
+            XxlJobLogger.log(logContent);
134
+        }
135
+    }
136
+
124 137
 }