Selaa lähdekoodia

重要重构;

xueli.xue 9 vuotta sitten
vanhempi
commit
9591be6b13
19 muutettua tiedostoa jossa 85 lisäystä ja 243 poistoa
  1. 3 9
      db/tables_xxl_job.sql
  2. 5 8
      xxl-job-admin/src/main/java/com/xxl/job/admin/controller/JobInfoController.java
  3. 10 19
      xxl-job-admin/src/main/java/com/xxl/job/admin/core/jobbean/RemoteHttpJobBean.java
  4. 12 29
      xxl-job-admin/src/main/java/com/xxl/job/admin/core/model/XxlJobInfo.java
  5. 0 28
      xxl-job-admin/src/main/java/com/xxl/job/admin/core/model/XxlJobLog.java
  6. 9 22
      xxl-job-admin/src/main/java/com/xxl/job/admin/core/thread/JobMonitorHelper.java
  7. 7 11
      xxl-job-admin/src/main/java/com/xxl/job/admin/core/util/DynamicSchedulerUtil.java
  8. 2 4
      xxl-job-admin/src/main/java/com/xxl/job/admin/service/IXxlJobService.java
  9. 2 9
      xxl-job-admin/src/main/java/com/xxl/job/admin/service/impl/XxlJobServiceImpl.java
  10. 1 1
      xxl-job-admin/src/main/resources/config.properties
  11. 1 15
      xxl-job-admin/src/main/resources/mybatis-mapper/XxlJobInfoMapper.xml
  12. 0 17
      xxl-job-admin/src/main/resources/mybatis-mapper/XxlJobLogMapper.xml
  13. 26 29
      xxl-job-admin/src/main/webapp/WEB-INF/template/jobinfo/jobinfo.index.ftl
  14. 0 4
      xxl-job-admin/src/main/webapp/WEB-INF/template/joblog/joblog.index.ftl
  15. 6 29
      xxl-job-admin/src/main/webapp/static/js/jobinfo.index.1.js
  16. 0 5
      xxl-job-admin/src/main/webapp/static/js/joblog.index.1.js
  17. 0 1
      xxl-job-admin/src/test/java/com/xxl/job/dao/impl/XxlJobInfoTest.java
  18. 0 2
      xxl-job-admin/src/test/java/com/xxl/job/dao/impl/XxlJobLogTest.java
  19. 1 1
      xxl-job-executor-example/src/main/java/com/xxl/job/executor/service/jobhandler/DemoJobHandler.java

+ 3 - 9
db/tables_xxl_job.sql Näytä tiedosto

@@ -145,20 +145,17 @@ CREATE TABLE XXL_JOB_QRTZ_LOCKS
145 145
 
146 146
 
147 147
 
148
-CREATE TABLE XXL_JOB_QRTZ_TRIGGER_INFO (
148
+CREATE TABLE `XXL_JOB_QRTZ_TRIGGER_INFO` (
149 149
   `id` int(11) NOT NULL AUTO_INCREMENT,
150 150
   `job_group` varchar(255) NOT NULL COMMENT '任务组',
151 151
   `job_name` varchar(255) NOT NULL COMMENT '任务名',
152 152
   `job_cron` varchar(128) NOT NULL COMMENT '任务执行CRON',
153 153
   `job_desc` varchar(255) NOT NULL,
154
-  `job_class` varchar(255) NOT NULL COMMENT '任务执行JobBean',
155 154
   `add_time` datetime DEFAULT NULL,
156 155
   `update_time` datetime DEFAULT NULL,
157 156
   `author` varchar(64) DEFAULT NULL COMMENT '作者',
158 157
   `alarm_email` varchar(255) DEFAULT NULL COMMENT '报警邮件',
159
-  `alarm_threshold` int(11) DEFAULT NULL COMMENT '报警阀值(连续失败次数)',
160 158
   `executor_address` varchar(255) DEFAULT NULL COMMENT '执行器地址,有多个则逗号分隔',
161
-  `executor_handler` varchar(255) DEFAULT NULL COMMENT '执行器任务handler',
162 159
   `executor_param` varchar(255) DEFAULT NULL COMMENT '执行器任务参数',
163 160
   `glue_switch` int(11) DEFAULT '0' COMMENT 'GLUE模式开关:0-否,1-是',
164 161
   `glue_source` text COMMENT 'GLUE源代码',
@@ -166,15 +163,12 @@ CREATE TABLE XXL_JOB_QRTZ_TRIGGER_INFO (
166 163
   PRIMARY KEY (`id`)
167 164
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
168 165
 
169
-CREATE TABLE XXL_JOB_QRTZ_TRIGGER_LOG (
166
+
167
+CREATE TABLE `XXL_JOB_QRTZ_TRIGGER_LOG` (
170 168
   `id` int(11) NOT NULL AUTO_INCREMENT,
171 169
   `job_group` varchar(255) NOT NULL COMMENT '任务组',
172 170
   `job_name` varchar(255) NOT NULL COMMENT '任务名',
173
-  `job_cron` varchar(128) NOT NULL COMMENT '任务执行CRON表达式',
174
-  `job_desc` varchar(255) NOT NULL,
175
-  `job_class` varchar(255) NOT NULL COMMENT '任务执行JobBean',
176 171
   `executor_address` varchar(255) DEFAULT NULL COMMENT '执行器地址,本次执行的地址',
177
-  `executor_handler` varchar(255) DEFAULT NULL COMMENT '执行器任务handler',
178 172
   `executor_param` varchar(255) DEFAULT NULL COMMENT 'executor_param',
179 173
   `trigger_time` datetime DEFAULT NULL COMMENT '调度-时间',
180 174
   `trigger_status` varchar(255) DEFAULT NULL COMMENT '调度-结果',

+ 5 - 8
xxl-job-admin/src/main/java/com/xxl/job/admin/controller/JobInfoController.java Näytä tiedosto

@@ -40,23 +40,20 @@ public class JobInfoController {
40 40
 	
41 41
 	@RequestMapping("/add")
42 42
 	@ResponseBody
43
-	public ReturnT<String> add(String jobGroup, String jobName, String jobCron, String jobDesc,
44
-			String executorAddress, String executorParam,
45
-			String author, String alarmEmail, int alarmThreshold, 
43
+	public ReturnT<String> add(String jobGroup, String jobCron, String jobDesc,
44
+			String executorAddress, String executorParam, String author, String alarmEmail,
46 45
 			int glueSwitch, String glueSource, String glueRemark) {
47 46
 		
48 47
 		return xxlJobService.add(jobGroup, jobCron, jobDesc, executorAddress, executorParam,
49
-				author, alarmEmail, alarmThreshold, glueSwitch, glueSource, glueRemark);
48
+				author, alarmEmail, glueSwitch, glueSource, glueRemark);
50 49
 	}
51 50
 	
52 51
 	@RequestMapping("/reschedule")
53 52
 	@ResponseBody
54 53
 	public ReturnT<String> reschedule(String jobGroup, String jobName, String jobCron, String jobDesc,
55
-			String executorAddress, String executorParam,
56
-			String author, String alarmEmail, int alarmThreshold) {
54
+			String executorAddress, String executorParam, String author, String alarmEmail) {
57 55
 
58
-		return xxlJobService.reschedule(jobGroup, jobName, jobCron, jobDesc, executorAddress, executorParam, author,
59
-				alarmEmail, alarmThreshold);
56
+		return xxlJobService.reschedule(jobGroup, jobName, jobCron, jobDesc, executorAddress, executorParam, author, alarmEmail);
60 57
 	}
61 58
 	
62 59
 	@RequestMapping("/remove")

+ 10 - 19
xxl-job-admin/src/main/java/com/xxl/job/admin/core/jobbean/RemoteHttpJobBean.java Näytä tiedosto

@@ -1,20 +1,5 @@
1 1
 package com.xxl.job.admin.core.jobbean;
2 2
 
3
-import java.text.MessageFormat;
4
-import java.util.Arrays;
5
-import java.util.Collections;
6
-import java.util.Date;
7
-import java.util.HashMap;
8
-import java.util.List;
9
-
10
-import org.apache.commons.lang.StringUtils;
11
-import org.quartz.JobExecutionContext;
12
-import org.quartz.JobExecutionException;
13
-import org.quartz.JobKey;
14
-import org.slf4j.Logger;
15
-import org.slf4j.LoggerFactory;
16
-import org.springframework.scheduling.quartz.QuartzJobBean;
17
-
18 3
 import com.xxl.job.admin.core.callback.XxlJobLogCallbackServer;
19 4
 import com.xxl.job.admin.core.model.XxlJobInfo;
20 5
 import com.xxl.job.admin.core.model.XxlJobLog;
@@ -24,6 +9,16 @@ import com.xxl.job.core.handler.HandlerRepository.ActionEnum;
24 9
 import com.xxl.job.core.handler.HandlerRepository.HandlerParamEnum;
25 10
 import com.xxl.job.core.util.HttpUtil;
26 11
 import com.xxl.job.core.util.HttpUtil.RemoteCallBack;
12
+import org.apache.commons.lang.StringUtils;
13
+import org.quartz.JobExecutionContext;
14
+import org.quartz.JobExecutionException;
15
+import org.quartz.JobKey;
16
+import org.slf4j.Logger;
17
+import org.slf4j.LoggerFactory;
18
+import org.springframework.scheduling.quartz.QuartzJobBean;
19
+
20
+import java.text.MessageFormat;
21
+import java.util.*;
27 22
 
28 23
 /**
29 24
  * http job bean
@@ -44,9 +39,6 @@ public class RemoteHttpJobBean extends QuartzJobBean {
44 39
 		XxlJobLog jobLog = new XxlJobLog();
45 40
 		jobLog.setJobGroup(jobInfo.getJobGroup());
46 41
 		jobLog.setJobName(jobInfo.getJobName());
47
-		jobLog.setJobCron(jobInfo.getJobCron());
48
-		jobLog.setJobDesc(jobInfo.getJobDesc());
49
-		jobLog.setJobClass(jobInfo.getJobClass());
50 42
 		DynamicSchedulerUtil.xxlJobLogDao.save(jobLog);
51 43
 		logger.info(">>>>>>>>>>> xxl-job trigger start, jobId:{}", jobLog.getId());
52 44
 		
@@ -66,7 +58,6 @@ public class RemoteHttpJobBean extends QuartzJobBean {
66 58
 
67 59
 		// failover trigger
68 60
 		RemoteCallBack callback = failoverTrigger(jobInfo.getExecutorAddress(), params, jobLog);
69
-		jobLog.setExecutorHandler(jobInfo.getGlueSwitch()==0?jobInfo.getExecutorHandler():"GLUE任务");
70 61
 		jobLog.setExecutorParam(jobInfo.getExecutorParam());
71 62
 		logger.info(">>>>>>>>>>> xxl-job failoverTrigger response, jobId:{}, callback:{}", jobLog.getId(), callback);
72 63
 		

+ 12 - 29
xxl-job-admin/src/main/java/com/xxl/job/admin/core/model/XxlJobInfo.java Näytä tiedosto

@@ -14,18 +14,14 @@ public class XxlJobInfo {
14 14
 	private String jobName;		// 任务名
15 15
 	private String jobCron;		// 任务执行CRON表达式 【base on quartz】
16 16
 	private String jobDesc;
17
-	private String jobClass;	// 任务执行JobBean 【base on quartz】
18
-	//private String jobData;		// 任务执行数据 Map-JSON-String
19 17
 	
20 18
 	private Date addTime;
21 19
 	private Date updateTime;
22 20
 	
23 21
 	private String author;		// 负责人
24 22
 	private String alarmEmail;	// 报警邮件
25
-	private int alarmThreshold;	// 报警阀值
26 23
 	
27 24
 	private String executorAddress;	// 执行器地址,有多个则逗号分隔
28
-	private String executorHandler;	// 执行器,任务Handler名称
29 25
 	private String executorParam;	// 执行器,任务参数
30 26
 	
31 27
 	private int glueSwitch;		// GLUE模式开关:0-否,1-是
@@ -35,6 +31,9 @@ public class XxlJobInfo {
35 31
 	// copy from quartz
36 32
 	private String jobStatus;	// 任务状态 【base on quartz】
37 33
 
34
+	// generate job key
35
+	private String jobKey;
36
+
38 37
 	public int getId() {
39 38
 		return id;
40 39
 	}
@@ -75,14 +74,6 @@ public class XxlJobInfo {
75 74
 		this.jobDesc = jobDesc;
76 75
 	}
77 76
 
78
-	public String getJobClass() {
79
-		return jobClass;
80
-	}
81
-
82
-	public void setJobClass(String jobClass) {
83
-		this.jobClass = jobClass;
84
-	}
85
-
86 77
 	public Date getAddTime() {
87 78
 		return addTime;
88 79
 	}
@@ -115,14 +106,6 @@ public class XxlJobInfo {
115 106
 		this.alarmEmail = alarmEmail;
116 107
 	}
117 108
 
118
-	public int getAlarmThreshold() {
119
-		return alarmThreshold;
120
-	}
121
-
122
-	public void setAlarmThreshold(int alarmThreshold) {
123
-		this.alarmThreshold = alarmThreshold;
124
-	}
125
-
126 109
 	public String getExecutorAddress() {
127 110
 		return executorAddress;
128 111
 	}
@@ -131,14 +114,6 @@ public class XxlJobInfo {
131 114
 		this.executorAddress = executorAddress;
132 115
 	}
133 116
 
134
-	public String getExecutorHandler() {
135
-		return executorHandler;
136
-	}
137
-
138
-	public void setExecutorHandler(String executorHandler) {
139
-		this.executorHandler = executorHandler;
140
-	}
141
-
142 117
 	public String getExecutorParam() {
143 118
 		return executorParam;
144 119
 	}
@@ -178,5 +153,13 @@ public class XxlJobInfo {
178 153
 	public void setJobStatus(String jobStatus) {
179 154
 		this.jobStatus = jobStatus;
180 155
 	}
181
-	
156
+
157
+	public String getJobKey() {
158
+		return jobGroup.concat("_").concat(jobName);
159
+	}
160
+
161
+	public void setJobKey(String jobKey) {
162
+		this.jobKey = jobKey;
163
+	}
164
+
182 165
 }

+ 0 - 28
xxl-job-admin/src/main/java/com/xxl/job/admin/core/model/XxlJobLog.java Näytä tiedosto

@@ -13,12 +13,8 @@ public class XxlJobLog {
13 13
 	// job info
14 14
 	private String jobGroup;
15 15
 	private String jobName;
16
-	private String jobCron;
17
-	private String jobDesc;
18
-	private String jobClass;
19 16
 	
20 17
 	private String executorAddress;	// 执行器地址,有多个则逗号分隔
21
-	private String executorHandler;	// 执行器,任务Handler名称
22 18
 	private String executorParam;	// 执行器,任务参数
23 19
 	
24 20
 	// trigger info
@@ -49,36 +45,12 @@ public class XxlJobLog {
49 45
 	public void setJobName(String jobName) {
50 46
 		this.jobName = jobName;
51 47
 	}
52
-	public String getJobCron() {
53
-		return jobCron;
54
-	}
55
-	public void setJobCron(String jobCron) {
56
-		this.jobCron = jobCron;
57
-	}
58
-	public String getJobDesc() {
59
-		return jobDesc;
60
-	}
61
-	public void setJobDesc(String jobDesc) {
62
-		this.jobDesc = jobDesc;
63
-	}
64
-	public String getJobClass() {
65
-		return jobClass;
66
-	}
67
-	public void setJobClass(String jobClass) {
68
-		this.jobClass = jobClass;
69
-	}
70 48
 	public String getExecutorAddress() {
71 49
 		return executorAddress;
72 50
 	}
73 51
 	public void setExecutorAddress(String executorAddress) {
74 52
 		this.executorAddress = executorAddress;
75 53
 	}
76
-	public String getExecutorHandler() {
77
-		return executorHandler;
78
-	}
79
-	public void setExecutorHandler(String executorHandler) {
80
-		this.executorHandler = executorHandler;
81
-	}
82 54
 	public String getExecutorParam() {
83 55
 		return executorParam;
84 56
 	}

+ 9 - 22
xxl-job-admin/src/main/java/com/xxl/job/admin/core/thread/JobMonitorHelper.java Näytä tiedosto

@@ -1,21 +1,16 @@
1 1
 package com.xxl.job.admin.core.thread;
2 2
 
3
-import java.text.MessageFormat;
4
-import java.util.concurrent.ConcurrentHashMap;
5
-import java.util.concurrent.ExecutorService;
6
-import java.util.concurrent.Executors;
7
-import java.util.concurrent.LinkedBlockingQueue;
8
-import java.util.concurrent.TimeUnit;
9
-
10
-import org.apache.commons.lang.StringUtils;
11
-import org.slf4j.Logger;
12
-import org.slf4j.LoggerFactory;
13
-
14 3
 import com.xxl.job.admin.core.model.XxlJobInfo;
15 4
 import com.xxl.job.admin.core.model.XxlJobLog;
16 5
 import com.xxl.job.admin.core.util.DynamicSchedulerUtil;
17 6
 import com.xxl.job.admin.core.util.MailUtil;
18 7
 import com.xxl.job.core.util.HttpUtil.RemoteCallBack;
8
+import org.apache.commons.lang.StringUtils;
9
+import org.slf4j.Logger;
10
+import org.slf4j.LoggerFactory;
11
+
12
+import java.text.MessageFormat;
13
+import java.util.concurrent.*;
19 14
 
20 15
 /**
21 16
  * job monitor helper
@@ -52,18 +47,10 @@ public class JobMonitorHelper {
52 47
 								// pass
53 48
 							}
54 49
 							if (RemoteCallBack.FAIL.equals(log.getTriggerStatus()) || RemoteCallBack.FAIL.equals(log.getHandleStatus())) {
55
-								String monotorKey = log.getJobGroup().concat("_").concat(log.getJobName());
56
-								Integer count = countMap.get(monotorKey);
57
-								if (count == null) {
58
-									count = new Integer(0);
59
-								}
60
-								count += 1;
61
-								countMap.put(monotorKey, count);
62 50
 								XxlJobInfo info = DynamicSchedulerUtil.xxlJobInfoDao.load(log.getJobGroup(), log.getJobName());
63
-								if (count >= info.getAlarmThreshold()) {
64
-									MailUtil.sendMail(info.getAlarmEmail(), "《调度平台中心-监控报警》", 
65
-											MessageFormat.format("调度任务[{0}]失败报警,连续失败次数:{1}", monotorKey, count), false, null);
66
-									countMap.remove(monotorKey);
51
+								if (info!=null && info.getAlarmEmail()!=null && info.getAlarmEmail().trim().length()>0) {
52
+									MailUtil.sendMail(info.getAlarmEmail(), "《调度监控报警-调度平台平台XXL-JOB》",
53
+											MessageFormat.format("任务调度失败, JobKey={0}, 任务描述:{1}.", info.getJobKey(), info.getJobDesc()), false, null);
67 54
 								}
68 55
 							}
69 56
 						}

+ 7 - 11
xxl-job-admin/src/main/java/com/xxl/job/admin/core/util/DynamicSchedulerUtil.java Näytä tiedosto

@@ -8,6 +8,7 @@ import java.util.List;
8 8
 import java.util.Map;
9 9
 import java.util.Set;
10 10
 
11
+import com.xxl.job.admin.core.jobbean.RemoteHttpJobBean;
11 12
 import org.quartz.CronScheduleBuilder;
12 13
 import org.quartz.CronTrigger;
13 14
 import org.quartz.Job;
@@ -130,7 +131,7 @@ public final class DynamicSchedulerUtil implements ApplicationContextAware, Init
130 131
         JobKey jobKey = new JobKey(jobInfo.getJobName(), jobInfo.getJobGroup());
131 132
         try {
132 133
 			Trigger trigger = scheduler.getTrigger(triggerKey);
133
-			JobDetail jobDetail = scheduler.getJobDetail(jobKey);
134
+
134 135
 			TriggerState triggerState = scheduler.getTriggerState(triggerKey);
135 136
 			
136 137
 			// parse params
@@ -138,10 +139,10 @@ public final class DynamicSchedulerUtil implements ApplicationContextAware, Init
138 139
 				String cronExpression = ((CronTriggerImpl) trigger).getCronExpression();
139 140
 				jobInfo.setJobCron(cronExpression);
140 141
 			}
141
-			if (jobDetail!=null) {
142
-				String jobClass = jobDetail.getJobClass().getName();
143
-				jobInfo.setJobClass(jobClass);
144
-			}
142
+
143
+            //JobDetail jobDetail = scheduler.getJobDetail(jobKey);
144
+            //String jobClass = jobDetail.getJobClass().getName();
145
+
145 146
 			if (triggerState!=null) {
146 147
 				jobInfo.setJobStatus(triggerState.name());
147 148
 			}
@@ -175,12 +176,7 @@ public final class DynamicSchedulerUtil implements ApplicationContextAware, Init
175 176
         CronTrigger cronTrigger = TriggerBuilder.newTrigger().withIdentity(triggerKey).withSchedule(cronScheduleBuilder).build();
176 177
 
177 178
         // JobDetail : jobClass
178
-		Class<? extends Job> jobClass_ = null;
179
-		try {
180
-			jobClass_ = (Class<? extends Job>)Class.forName(jobInfo.getJobClass());
181
-		} catch (ClassNotFoundException e) {
182
-			e.printStackTrace();
183
-		}
179
+		Class<? extends Job> jobClass_ = RemoteHttpJobBean.class;   // Class.forName(jobInfo.getJobClass());
184 180
         
185 181
 		JobDetail jobDetail = JobBuilder.newJob(jobClass_).withIdentity(jobKey).build();
186 182
         /*if (jobInfo.getJobData()!=null) {

+ 2 - 4
xxl-job-admin/src/main/java/com/xxl/job/admin/service/IXxlJobService.java Näytä tiedosto

@@ -14,13 +14,11 @@ public interface IXxlJobService {
14 14
 	public Map<String, Object> pageList(int start, int length, String jobGroup, String jobDesc, String filterTime);
15 15
 	
16 16
 	public ReturnT<String> add(String jobGroup, String jobCron, String jobDesc,
17
-			String executorAddress,	String executorParam,
18
-			String author, String alarmEmail, int alarmThreshold,
17
+			String executorAddress,	String executorParam, String author, String alarmEmail,
19 18
 			int glueSwitch, String glueSource, String glueRemark);
20 19
 	
21 20
 	public ReturnT<String> reschedule(String jobGroup, String jobName, String jobCron, String jobDesc,
22
-			String handler_address, String handler_params,
23
-			String author, String alarmEmail, int alarmThreshold);
21
+			String handler_address, String handler_params, String author, String alarmEmail);
24 22
 	
25 23
 	public ReturnT<String> remove(String jobGroup, String jobName);
26 24
 	

+ 2 - 9
xxl-job-admin/src/main/java/com/xxl/job/admin/service/impl/XxlJobServiceImpl.java Näytä tiedosto

@@ -59,8 +59,7 @@ public class XxlJobServiceImpl implements IXxlJobService {
59 59
 
60 60
 	@Override
61 61
 	public ReturnT<String> add(String jobGroup, String jobCron, String jobDesc,
62
-			String executorAddress,	String executorParam,
63
-			String author, String alarmEmail, int alarmThreshold,
62
+			String executorAddress,	String executorParam, String author, String alarmEmail,
64 63
 			int glueSwitch, String glueSource, String glueRemark) {
65 64
 		// valid
66 65
 		if (JobGroupEnum.match(jobGroup) == null) {
@@ -81,9 +80,6 @@ public class XxlJobServiceImpl implements IXxlJobService {
81 80
 		if (StringUtils.isBlank(alarmEmail)) {
82 81
 			return new ReturnT<String>(500, "请输入“报警邮件”");
83 82
 		}
84
-		if (alarmThreshold < 0) {
85
-			alarmThreshold = 0;
86
-		}
87 83
 
88 84
 		// generate jobName
89 85
 		String jobName = FastDateFormat.getInstance("yyyyMMddHHmmssSSSS").format(new Date());
@@ -102,10 +98,8 @@ public class XxlJobServiceImpl implements IXxlJobService {
102 98
 		jobInfo.setJobName(jobName);
103 99
 		jobInfo.setJobCron(jobCron);
104 100
 		jobInfo.setJobDesc(jobDesc);
105
-		jobInfo.setJobClass(RemoteHttpJobBean.class.getName());
106 101
 		jobInfo.setAuthor(author);
107 102
 		jobInfo.setAlarmEmail(alarmEmail);
108
-		jobInfo.setAlarmThreshold(alarmThreshold);
109 103
 		jobInfo.setGlueSwitch(glueSwitch);
110 104
 		jobInfo.setGlueSource(glueSource);
111 105
 		jobInfo.setGlueRemark(glueRemark);
@@ -131,7 +125,7 @@ public class XxlJobServiceImpl implements IXxlJobService {
131 125
 	@Override
132 126
 	public ReturnT<String> reschedule(String jobGroup, String jobName, String jobCron, String jobDesc,
133 127
 			String executorAddress, String executorParam,
134
-			String author, String alarmEmail, int alarmThreshold) {
128
+			String author, String alarmEmail) {
135 129
 		
136 130
 		// valid
137 131
 		if (JobGroupEnum.match(jobGroup) == null) {
@@ -161,7 +155,6 @@ public class XxlJobServiceImpl implements IXxlJobService {
161 155
 		jobInfo.setJobCron(jobCron);
162 156
 		jobInfo.setAuthor(author);
163 157
 		jobInfo.setAlarmEmail(alarmEmail);
164
-		jobInfo.setAlarmThreshold(alarmThreshold);
165 158
 		jobInfo.setExecutorAddress(executorAddress);
166 159
 		jobInfo.setExecutorParam(executorParam);
167 160
 		

+ 1 - 1
xxl-job-admin/src/main/resources/config.properties Näytä tiedosto

@@ -4,7 +4,7 @@ mail.port=25
4 4
 mail.username=ovono802302@163.com
5 5
 mail.password=asdfzxcv
6 6
 mail.sendFrom=ovono802302@163.com
7
-mail.sendNick=《任务调度中心xxl-job
7
+mail.sendNick=《调度平台平台XXL-JOB
8 8
 
9 9
 # for login
10 10
 login.username=admin

+ 1 - 15
xxl-job-admin/src/main/resources/mybatis-mapper/XxlJobInfoMapper.xml Näytä tiedosto

@@ -10,17 +10,14 @@
10 10
 	    <result column="job_name" property="jobName" />
11 11
 	    <result column="job_cron" property="jobCron" />
12 12
 	    <result column="job_desc" property="jobDesc" />
13
-	    <result column="job_class" property="jobClass" />
14 13
 	    
15 14
 	    <result column="add_time" property="addTime" />
16 15
 	    <result column="update_time" property="updateTime" />
17 16
 	    
18 17
 	    <result column="author" property="author" />
19 18
 	    <result column="alarm_email" property="alarmEmail" />
20
-	    <result column="alarm_threshold" property="alarmThreshold" />
21 19
 	    
22 20
 	    <result column="executor_address" property="executorAddress" />
23
-	    <result column="executor_handler" property="executorHandler" />
24 21
 	    <result column="executor_param" property="executorParam" />
25 22
 	    
26 23
 	    <result column="glue_switch" property="glueSwitch" />
@@ -34,14 +31,11 @@
34 31
 		t.job_name,
35 32
 		t.job_cron,
36 33
 		t.job_desc,
37
-		t.job_class,
38 34
 		t.add_time,
39 35
 		t.update_time,
40 36
 		t.author,
41 37
 		t.alarm_email,
42
-		t.alarm_threshold,
43 38
 		t.executor_address,
44
-		t.executor_handler,
45 39
 		t.executor_param,
46 40
 		t.glue_switch,
47 41
 		t.glue_source,
@@ -82,14 +76,11 @@
82 76
 			job_name,
83 77
 			job_cron,
84 78
 			job_desc,
85
-			job_class,
86 79
 			add_time,
87 80
 			update_time,
88 81
 			author,
89 82
 			alarm_email,
90
-			alarm_threshold,
91 83
 			executor_address,
92
-			executor_handler,
93 84
 			executor_param,
94 85
 			glue_switch,
95 86
 			glue_source,
@@ -98,15 +89,12 @@
98 89
 			#{jobGroup}, 
99 90
 			#{jobName}, 
100 91
 			#{jobCron}, 
101
-			#{jobDesc}, 
102
-			#{jobClass}, 
92
+			#{jobDesc},
103 93
 			NOW(),
104 94
 			NOW(),
105 95
 			#{author},
106 96
 			#{alarmEmail},
107
-			#{alarmThreshold},
108 97
 			#{executorAddress},
109
-			#{executorHandler},
110 98
 			#{executorParam},
111 99
 			#{glueSwitch},
112 100
 			#{glueSource},
@@ -132,9 +120,7 @@
132 120
 			update_time = NOW(),
133 121
 			author = #{author},
134 122
 			alarm_email = #{alarmEmail},
135
-			alarm_threshold = #{alarmThreshold},
136 123
 			executor_address = #{executorAddress},
137
-			executor_handler = #{executorHandler},
138 124
 			executor_param = #{executorParam},
139 125
 			glue_switch = #{glueSwitch},
140 126
 			glue_source = #{glueSource},

+ 0 - 17
xxl-job-admin/src/main/resources/mybatis-mapper/XxlJobLogMapper.xml Näytä tiedosto

@@ -8,12 +8,8 @@
8 8
 	
9 9
 	    <result column="job_group" property="jobGroup" />
10 10
 	    <result column="job_name" property="jobName" />
11
-	    <result column="job_cron" property="jobCron" />
12
-	    <result column="job_desc" property="jobDesc" />
13
-	    <result column="job_class" property="jobClass" />
14 11
 	    
15 12
 	    <result column="executor_address" property="executorAddress" />
16
-	    <result column="executor_handler" property="executorHandler" />
17 13
 	    <result column="executor_param" property="executorParam" />
18 14
 	    
19 15
 	    <result column="trigger_time" property="triggerTime" />
@@ -30,11 +26,7 @@
30 26
 		t.id,
31 27
 		t.job_group,
32 28
 		t.job_name,
33
-		t.job_cron,
34
-		t.job_desc,
35
-		t.job_class,
36 29
 		t.executor_address,
37
-		t.executor_handler,
38 30
 		t.executor_param,
39 31
 		t.trigger_time,
40 32
 		t.trigger_status,
@@ -101,20 +93,12 @@
101 93
 		INSERT INTO XXL_JOB_QRTZ_TRIGGER_LOG (
102 94
 			`job_group`,
103 95
 			`job_name`,
104
-			`job_cron`, 
105
-			`job_desc`,
106
-			`job_class`, 
107 96
 			`executor_address`,
108
-			`executor_handler`,
109 97
 			`executor_param`
110 98
 		) VALUES (
111 99
 			#{jobGroup}, 
112 100
 			#{jobName},
113
-			#{jobCron},
114
-			#{jobDesc},
115
-			#{jobClass},
116 101
 			#{executorAddress},
117
-			#{executorHandler},
118 102
 			#{executorParam}
119 103
 		);
120 104
 		<selectKey resultType="java.lang.Integer" order="AFTER" keyProperty="id"> 
@@ -129,7 +113,6 @@
129 113
 			`trigger_status`= #{triggerStatus}, 
130 114
 			`trigger_msg`= #{triggerMsg},
131 115
 			`executor_address`= #{executorAddress},
132
-			`executor_handler`= #{executorHandler},
133 116
 			`executor_param`= #{executorParam}
134 117
 		WHERE `id`= #{id}
135 118
 	</update>

+ 26 - 29
xxl-job-admin/src/main/webapp/WEB-INF/template/jobinfo/jobinfo.index.ftl Näytä tiedosto

@@ -38,7 +38,7 @@
38 38
 	    <section class="content">
39 39
 	    
40 40
 	    	<div class="row">
41
-	    		<div class="col-xs-4">
41
+	    		<div class="col-xs-2">
42 42
 	              	<div class="input-group">
43 43
 	                	<span class="input-group-addon">分组</span>
44 44
                 		<select class="form-control" id="jobGroup" >
@@ -48,9 +48,15 @@
48 48
 	                  	</select>
49 49
 	              	</div>
50 50
 	            </div>
51
-	            <div class="col-xs-4">
51
+                <div class="col-xs-3">
52
+                    <div class="input-group">
53
+                        <span class="input-group-addon">JobKey</span>
54
+                        <input type="text" class="form-control" id="JobKey" value="${jobName}" autocomplete="on" >
55
+                    </div>
56
+                </div>
57
+	            <div class="col-xs-3">
52 58
 	              	<div class="input-group">
53
-	                	<span class="input-group-addon">名称</span>
59
+	                	<span class="input-group-addon">描述</span>
54 60
 	                	<input type="text" class="form-control" id="jobDesc" value="${jobName}" autocomplete="on" >
55 61
 	              	</div>
56 62
 	            </div>
@@ -75,16 +81,15 @@
75 81
 					            		<th name="id" >id</th>
76 82
 					                	<th name="jobGroup" >jobGroup</th>
77 83
 					                  	<th name="jobName" >jobName</th>
78
-					                  	<th name="jobDesc" >名称</th>
84
+                                        <th name="JobKey" >JobKey</th>
85
+					                  	<th name="jobDesc" >描述</th>
79 86
 					                  	<th name="jobCron" >Cron</th>
80
-					                  	<th name="jobClass" >JobBean</th>
81 87
 					                  	<th name="executorAddress" >执行器地址</th>
82 88
 					                  	<th name="executorParam" >任务参数</th>
83 89
 					                  	<th name="addTime" >新增时间</th>
84 90
 					                  	<th name="updateTime" >更新时间</th>
85 91
 					                  	<th name="author" >负责人</th>
86 92
 					                  	<th name="alarmEmail" >报警邮件</th>
87
-					                  	<th name="alarmThreshold" >报警阀值</th>
88 93
 					                  	<th name="glueSwitch" >GLUE模式</th>
89 94
 					                  	<th name="jobStatus" >状态</th>
90 95
 					                  	<th>操作</th>
@@ -122,7 +127,7 @@
122 127
 		            			</#list>
123 128
 		                  	</select>
124 129
 						</div>
125
-                        <label for="lastname" class="col-sm-2 control-label">名称<font color="red">*</font></label>
130
+                        <label for="lastname" class="col-sm-2 control-label">描述<font color="red">*</font></label>
126 131
                         <div class="col-sm-4"><input type="text" class="form-control" name="jobDesc" placeholder="请输入“描述”" maxlength="50" ></div>
127 132
 					</div>
128 133
 					<div class="form-group">
@@ -134,16 +139,6 @@
134 139
 					<div class="form-group">
135 140
                         <label for="firstname" class="col-sm-2 control-label">执行参数<font color="black">*</font></label>
136 141
                         <div class="col-sm-4"><input type="text" class="form-control" name="executorParam" placeholder="请输入“执行参数”" maxlength="100" ></div>
137
-                        <label for="lastname" class="col-sm-2 control-label">负责人<font color="red">*</font></label>
138
-                        <div class="col-sm-4"><input type="text" class="form-control" name="author" placeholder="请输入“负责人”" maxlength="50" ></div>
139
-					</div>
140
-					<div class="form-group">
141
-						<label for="lastname" class="col-sm-2 control-label">报警邮件<font color="red">*</font></label>
142
-						<div class="col-sm-4"><input type="text" class="form-control" name="alarmEmail" placeholder="请输入“报警邮件”,多个邮件地址逗号分隔" maxlength="100" ></div>
143
-						<label for="lastname" class="col-sm-2 control-label">报警阈值<font color="red">*</font></label>
144
-						<div class="col-sm-4"><input type="text" class="form-control" name="alarmThreshold" placeholder="请输入“报警阈值”" maxlength="5" ></div>
145
-					</div>
146
-                    <div class="form-group">
147 142
                         <label for="firstname" class="col-sm-2 control-label">任务模式<font color="red">*</font></label>
148 143
                         <div class="col-sm-4">
149 144
                             <select class="form-control" name="glueSwitch" >
@@ -151,7 +146,13 @@
151 146
                                 <option value="1" >GLUE模式</option>
152 147
                             </select>
153 148
                         </div>
154
-                    </div>
149
+					</div>
150
+					<div class="form-group">
151
+						<label for="lastname" class="col-sm-2 control-label">报警邮件<font color="red">*</font></label>
152
+						<div class="col-sm-4"><input type="text" class="form-control" name="alarmEmail" placeholder="请输入“报警邮件”,多个邮件地址逗号分隔" maxlength="100" ></div>
153
+                        <label for="lastname" class="col-sm-2 control-label">负责人<font color="red">*</font></label>
154
+                        <div class="col-sm-4"><input type="text" class="form-control" name="author" placeholder="请输入“负责人”" maxlength="50" ></div>
155
+					</div>
155 156
                     <hr>
156 157
 					<div class="form-group">
157 158
 						<div class="col-sm-offset-3 col-sm-6">
@@ -202,7 +203,7 @@ public class DemoJobHandler extends IJobHandler {
202 203
                         <div class="col-sm-4">
203 204
 							<input type="text" class="form-control jobGroupTitle" maxlength="50" readonly >
204 205
 						</div>
205
-                        <label for="lastname" class="col-sm-2 control-label">名称<font color="red">*</font></label>
206
+                        <label for="lastname" class="col-sm-2 control-label">描述<font color="red">*</font></label>
206 207
                         <div class="col-sm-4"><input type="text" class="form-control" name="jobDesc" placeholder="请输入“描述”" maxlength="50" ></div>
207 208
 					</div>
208 209
 					<div class="form-group">
@@ -215,21 +216,17 @@ public class DemoJobHandler extends IJobHandler {
215 216
 					<div class="form-group">
216 217
                         <label for="firstname" class="col-sm-2 control-label">执行参数<font color="black">*</font></label>
217 218
                         <div class="col-sm-4"><input type="text" class="form-control" name="executorParam" placeholder="请输入“执行参数”" maxlength="100" ></div>
218
-                        <label for="lastname" class="col-sm-2 control-label">负责人<font color="red">*</font></label>
219
-                        <div class="col-sm-4"><input type="text" class="form-control" name="author" placeholder="请输入“负责人”" maxlength="50" ></div>
219
+                        <label for="firstname" class="col-sm-2 control-label">任务模式<font color="red">*</font></label>
220
+                        <div class="col-sm-4">
221
+                            <input type="text" class="form-control glueSwitchTitle" readonly >
222
+                        </div>
220 223
 					</div>
221 224
 					<div class="form-group">
222 225
 						<label for="lastname" class="col-sm-2 control-label">报警邮件<font color="red">*</font></label>
223 226
 						<div class="col-sm-4"><input type="text" class="form-control" name="alarmEmail" placeholder="请输入“报警邮件”,多个邮件地址逗号分隔" maxlength="100" ></div>
224
-						<label for="lastname" class="col-sm-2 control-label">报警阈值<font color="red">*</font></label>
225
-						<div class="col-sm-4"><input type="text" class="form-control" name="alarmThreshold" placeholder="请输入“报警阈值”" maxlength="5" ></div>
227
+                        <label for="lastname" class="col-sm-2 control-label">负责人<font color="red">*</font></label>
228
+                        <div class="col-sm-4"><input type="text" class="form-control" name="author" placeholder="请输入“负责人”" maxlength="50" ></div>
226 229
 					</div>
227
-                    <div class="form-group">
228
-                        <label for="firstname" class="col-sm-2 control-label">任务模式<font color="red">*</font></label>
229
-                        <div class="col-sm-4">
230
-							<input type="text" class="form-control glueSwitchTitle" readonly >
231
-						</div>
232
-                    </div>
233 230
 					<hr>
234 231
 					<div class="form-group">
235 232
 						<div class="col-sm-offset-3 col-sm-3">

+ 0 - 4
xxl-job-admin/src/main/webapp/WEB-INF/template/joblog/joblog.index.ftl Näytä tiedosto

@@ -78,11 +78,7 @@
78 78
 					                	<th name="id" >id</th>
79 79
 					                	<th name="jobGroup" >任务组</th>
80 80
 					                  	<th name="jobName" >任务名</th>
81
-					                  	<th name="jobCron" >Cron</th>
82
-					                  	<th name="jobDesc" >描述</th>
83
-					                  	<th name="jobClass" >JobBean</th>
84 81
 					                  	<th name="executorAddress" >执行器地址</th>
85
-					                  	<th name="executorHandler" >JobHandler</th>
86 82
 					                  	<th name="executorParam" >任务参数</th>
87 83
 					                  	<th name="triggerTime" >调度时间</th>
88 84
 					                  	<th name="triggerStatus" >调度结果</th>

+ 6 - 29
xxl-job-admin/src/main/webapp/static/js/jobinfo.index.1.js Näytä tiedosto

@@ -34,10 +34,10 @@ $(function() {
34 34
 	            			return data;
35 35
 	            		}
36 36
             		},
37
-	                { "data": 'jobName', "visible" : false},
37
+					{ "data": 'jobName', "visible" : false},
38
+					{ "data": 'jobKey', "visible" : true},
38 39
 	                { "data": 'jobDesc', "visible" : true},
39 40
 	                { "data": 'jobCron', "visible" : true},
40
-	                { "data": 'jobClass', "visible" : false},
41 41
 	                { "data": 'executorAddress', "visible" : false},
42 42
 	                { "data": 'executorParam', "visible" : false},
43 43
 	                { 
@@ -56,7 +56,6 @@ $(function() {
56 56
 	                },
57 57
 	                { "data": 'author', "visible" : true},
58 58
 	                { "data": 'alarmEmail', "visible" : false},
59
-	                { "data": 'alarmThreshold', "visible" : false},
60 59
 	                { "data": 'glueSwitch', "visible" : false},
61 60
 	                { 
62 61
 	                	"data": 'jobStatus', 
@@ -95,14 +94,13 @@ $(function() {
95 94
 	                			var html = '<p id="'+ row.id +'" '+
96 95
 	                							' jobGroup="'+ row.jobGroup +'" '+
97 96
 	                							' jobName="'+ row.jobName +'" '+
97
+												' jobKey="'+ row.jobKey +'" '+
98 98
 	                							' jobCron="'+ row.jobCron +'" '+
99 99
 	                							' jobDesc="'+ row.jobDesc +'" '+
100
-	                							' jobClass="'+ row.jobClass +'" '+
101 100
 	                							' executorAddress="'+row.executorAddress +'" '+
102 101
 	                							' executorParam="'+ row.executorParam +'" '+
103 102
 	                							' author="'+ row.author +'" '+
104 103
 	                							' alarmEmail="'+ row.alarmEmail +'" '+
105
-	                							' alarmThreshold="'+ row.alarmThreshold +'" '+
106 104
 	                							' glueSwitch="'+ row.glueSwitch +'" '+
107 105
 	                							'>'+
108 106
 										'<button class="btn btn-primary btn-xs job_operate" type="job_trigger" type="button">执行</button>  '+
@@ -226,17 +224,13 @@ $(function() {
226 224
             alarmEmail : {
227 225
             	required : true
228 226
             },
229
-            alarmThreshold : {
230
-            	required : true ,
231
-            	digits:true
232
-            },
233 227
 			author : {
234 228
 				required : true
235 229
 			}
236 230
         }, 
237 231
         messages : {  
238 232
             jobDesc : {
239
-            	required :"请输入“名称”."
233
+            	required :"请输入“描述”."
240 234
             },
241 235
             jobCron : {
242 236
             	required :"请输入“Cron”."
@@ -247,10 +241,6 @@ $(function() {
247 241
             alarmEmail : {
248 242
             	required : "请输入“报警邮件”."
249 243
             },
250
-            alarmThreshold : {
251
-            	required : "请输入“报警阈值”."  ,
252
-            	digits:"阀值应该为整数."
253
-            },
254 244
             author : {
255 245
             	required : "请输入“负责人”."
256 246
             }
@@ -294,26 +284,21 @@ $(function() {
294 284
 		// base data
295 285
 		$("#updateModal .form input[name='jobGroup']").val($(this).parent('p').attr("jobGroup"));
296 286
 		$("#updateModal .form input[name='jobName']").val($(this).parent('p').attr("jobName"));
287
+		$("#updateModal .form .jobKey").val( $(this).parent('p').attr("jobKey") );
297 288
 		$("#updateModal .form input[name='jobDesc']").val($(this).parent('p').attr("jobDesc"));
298 289
 		$("#updateModal .form input[name='jobCron']").val($(this).parent('p').attr("jobCron"));
299 290
 		$("#updateModal .form input[name='executorAddress']").val($(this).parent('p').attr("executorAddress"));
300 291
 		$("#updateModal .form input[name='executorParam']").val($(this).parent('p').attr("executorParam"));
301 292
 		$("#updateModal .form input[name='author']").val($(this).parent('p').attr("author"));
302 293
 		$("#updateModal .form input[name='alarmEmail']").val($(this).parent('p').attr("alarmEmail"));
303
-		$("#updateModal .form input[name='alarmThreshold']").val($(this).parent('p').attr("alarmThreshold"));
304 294
 
305 295
 		// jobGroupTitle
306 296
 		var jobGroupTitle = $("#addModal .form select[name='jobGroup']").find("option[value='" + $(this).parent('p').attr("jobGroup") + "']").text();
307 297
 		$("#updateModal .form .jobGroupTitle").val(jobGroupTitle);
308 298
 
309
-        // jobKey
310
-        var jobKey = $(this).parent('p').attr("jobGroup") + "_" + $(this).parent('p').attr("jobName");
311
-        $("#updateModal .form .jobKey").val(jobKey);
312
-
313 299
         // glueSwitchTitle
314 300
 		$("#updateModal .form .glueSwitchTitle").val( ($(this).parent('p').attr("glueSwitch") == 0)?"BEAN模式":"GLUE模式" );
315 301
 
316
-
317 302
 		// show
318 303
 		$('#updateModal').modal({backdrop: false, keyboard: false}).modal('show');
319 304
 	});
@@ -336,17 +321,13 @@ $(function() {
336 321
 			alarmEmail : {
337 322
 				required : true
338 323
 			},
339
-			alarmThreshold : {
340
-				required : true ,
341
-				digits:true
342
-			},
343 324
 			author : {
344 325
 				required : true
345 326
 			}
346 327
 		},
347 328
 		messages : {
348 329
 			jobDesc : {
349
-				required :"请输入“名称”."
330
+				required :"请输入“描述”."
350 331
 			},
351 332
 			jobCron : {
352 333
 				required :"请输入“Cron”."
@@ -357,10 +338,6 @@ $(function() {
357 338
 			alarmEmail : {
358 339
 				required : "请输入“报警邮件”."
359 340
 			},
360
-			alarmThreshold : {
361
-				required : "请输入“报警阈值”."  ,
362
-				digits:"阀值应该为整数."
363
-			},
364 341
 			author : {
365 342
 				required : "请输入“负责人”."
366 343
 			}

+ 0 - 5
xxl-job-admin/src/main/webapp/static/js/joblog.index.1.js Näytä tiedosto

@@ -96,12 +96,7 @@ $(function() {
96 96
 	            		}
97 97
             		},
98 98
 	                { "data": 'jobName', "visible" : false},
99
-	                { "data": 'jobCron', "visible" : false},
100
-	                { "data": 'jobDesc', "visible" : false},
101
-	                { "data": 'jobClass', "visible" : false},
102
-	                
103 99
 	                { "data": 'executorAddress', "visible" : true},
104
-	                { "data": 'executorHandler', "visible" : true},
105 100
 	                { "data": 'executorParam', "visible" : true},
106 101
 	                { 
107 102
 	                	"data": 'triggerTime', 

+ 0 - 1
xxl-job-admin/src/test/java/com/xxl/job/dao/impl/XxlJobInfoTest.java Näytä tiedosto

@@ -33,7 +33,6 @@ public class XxlJobInfoTest {
33 33
 		XxlJobInfo info = new XxlJobInfo();
34 34
 		info.setJobName("job_name");
35 35
 		info.setJobCron("jobCron");
36
-		info.setJobClass("jobClass");
37 36
 		int count = xxlJobInfoDao.save(info);
38 37
 		System.out.println(count);
39 38
 		System.out.println(info.getId());

+ 0 - 2
xxl-job-admin/src/test/java/com/xxl/job/dao/impl/XxlJobLogTest.java Näytä tiedosto

@@ -26,8 +26,6 @@ public class XxlJobLogTest {
26 26
 	public void save_load(){
27 27
 		XxlJobLog xxlJobLog = new XxlJobLog();
28 28
 		xxlJobLog.setJobName("job_name");
29
-		xxlJobLog.setJobCron("jobCron");
30
-		xxlJobLog.setJobClass("jobClass");
31 29
 		int count = xxlJobLogDao.save(xxlJobLog);
32 30
 		System.out.println(count);
33 31
 		System.out.println(xxlJobLog.getId());

+ 1 - 1
xxl-job-executor-example/src/main/java/com/xxl/job/executor/service/jobhandler/DemoJobHandler.java Näytä tiedosto

@@ -20,7 +20,7 @@ import com.xxl.job.core.handler.annotation.JobHander;
20 20
  * 
21 21
  * @author xuxueli 2015-12-19 19:43:36
22 22
  */
23
-@JobHander(value="defaults_201607192256270689,defaults_201607192256270689")
23
+@JobHander(value="waimai_201607202316260736,waimai_201607202316260736")
24 24
 @Service
25 25
 public class DemoJobHandler extends IJobHandler {
26 26
 	private static transient Logger logger = LoggerFactory.getLogger(DemoJobHandler.class);